Allow info logs for ai.chronon.spark for dataproc. #194

david-zlai · 2025-01-10T00:57:35Z

Summary

Checklist

Added Unit Tests
Covered by existing CI
Integration tested
Documentation update

Summary by CodeRabbit

New Features
- Enhanced logging configuration for Spark job submission process.
- Added ability to set logging level for "ai.chronon.spark" logger to INFO level.

coderabbitai · 2025-01-10T00:57:43Z

Walkthrough

The pull request introduces a logging configuration enhancement for the Spark job submission process in the DataprocSubmitter class. A new import for LoggingConfig.Level is added, and the submit method now includes a logging configuration that sets the "ai.chronon.spark" logger to INFO level. This change provides more granular control over log output during job submission without modifying the core functionality of the class.

Changes

File	Change Summary
`cloud_gcp/src/main/scala/.../DataprocSubmitter.scala`	- Added import for `LoggingConfig.Level` - Integrated logging configuration in `submit` method - Set "ai.chronon.spark" logger to INFO level

Possibly related PRs

feat: enable slf4j logging to work with logback #76: The changes in this PR enhance logging capabilities, which is directly related to the new logging configuration introduced in the main PR for the DataprocSubmitter class.
feat: implement Dataproc spark submitter utility #122: This PR implements the DataprocSubmitter utility, which includes the submit method that has been modified in the main PR to incorporate new logging functionality.

Suggested Reviewers

tchow-zlai
piyush-zlai
chewy-zlai

Poem

🌟 Logging Whispers in the Cloud 🌟

Spark jobs dance with INFO's light,
Dataproc submits with logging might,
Configurations bloom so bright,
Tracing paths through digital height,
A logger's tale of pure delight! 🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 0a5949a and 2958a9d.

📒 Files selected for processing (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: scala_compile_fmt_fix

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1)

55-59: Consider making log level configurable

Hard-coded INFO level could be moved to SubmitterConf for flexibility.

 case class SubmitterConf(
     projectId: String,
     region: String,
     clusterName: String,
     jarUri: String,
-    mainClass: String
+    mainClass: String,
+    sparkLogLevel: Level = Level.INFO
 ) {
   def endPoint: String = s"${region}-dataproc.googleapis.com:443"
 }

 // In submit method:
       .setLoggingConfig(
         LoggingConfig
           .newBuilder()
-          .putDriverLogLevels("ai.chronon.spark", Level.INFO)
+          .putDriverLogLevels("ai.chronon.spark", conf.sparkLogLevel)
           .build())

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 521e67c and 0a5949a.

📒 Files selected for processing (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1)

5-5: LGTM!

Clean import addition for logging configuration.

tchow-zlai

LGTM

piyush-zlai · 2025-01-10T04:28:11Z

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala

      .addAllFileUris(files.asJava)
      .addAllArgs(args.toIterable.asJava)
+      .setLoggingConfig(
+        LoggingConfig


curious - we can't configure this via log4j2 properties?

if it's not straightforward maybe we can create a ticket and follow up ?

## Summary ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **New Features** - Enhanced logging configuration for Spark job submission process. - Added ability to set logging level for "ai.chronon.spark" logger to INFO level.

## Summary ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **New Features** - Enhanced logging configuration for Spark job submission process. - Added ability to set logging level for "ai.chronon.spark" logger to INFO level.

Allow info logs for ai.chronon.spark for dataproc.

0a5949a

david-zlai requested a review from tchow-zlai January 10, 2025 00:57

coderabbitai bot reviewed Jan 10, 2025

View reviewed changes

tchow-zlai approved these changes Jan 10, 2025

View reviewed changes

piyush-zlai approved these changes Jan 10, 2025

View reviewed changes

add space

2958a9d

david-zlai merged commit 991f127 into main Jan 10, 2025
4 checks passed

david-zlai deleted the davidhan/setlogging branch January 10, 2025 20:17

This was referenced Jan 10, 2025

HOTFIX: Logging config programatically #202

Merged

Add script to upload cloud gcp jars to appropriate bucket. #203

Merged

coderabbitai bot mentioned this pull request Jan 24, 2025

feat: use normal spark rails to parse arguments #273

Closed

4 tasks

coderabbitai bot mentioned this pull request Jan 31, 2025

Change log level to info for when no partitions found or unreachable table. #312

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow info logs for ai.chronon.spark for dataproc. #194

Allow info logs for ai.chronon.spark for dataproc. #194

Uh oh!

david-zlai commented Jan 10, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 10, 2025 •

edited

Loading

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

tchow-zlai left a comment

Uh oh!

piyush-zlai Jan 10, 2025

Uh oh!

tchow-zlai Jan 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Allow info logs for ai.chronon.spark for dataproc. #194

Allow info logs for ai.chronon.spark for dataproc. #194

Uh oh!

Conversation

david-zlai commented Jan 10, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested Reviewers

Poem

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

tchow-zlai left a comment

Choose a reason for hiding this comment

Uh oh!

piyush-zlai Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

tchow-zlai Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

david-zlai commented Jan 10, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)