chore: simplify some Extensions

[tchow-zlai]

Summary

• Slim down Extensions. Remove some unused methods and use builtins for the others.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor

  • Simplified collection conversions between Scala and Java Maps in multiple Spark utility classes
  • Removed two implicit utility classes related to internal row and tuple handling

• Chores

  • Updated code to use more idiomatic Scala collection transformations
  • Maintained existing functionality while improving code clarity

[coderabbitai]

Walkthrough

The pull request involves removing two implicit classes (InternalRowOps and TupleToJMapOps) from the Extensions.scala file and making consistent changes in collection conversions across multiple Spark-related utility classes. The modifications primarily focus on standardizing how Scala and Java collections are handled, specifically replacing .toJMap with .toMap.asJava in methods like computeRange and genBloomFilterIfNeeded.

Changes

File	Change Summary
spark/src/main/scala/ai/chronon/spark/Extensions.scala	Removed InternalRowOps and TupleToJMapOps implicit classes
spark/src/main/scala/ai/chronon/spark/Join.scala	Updated collection conversion in computeRange from .toJMap to .toMap.asJava
spark/src/main/scala/ai/chronon/spark/JoinUtils.scala	Modified map creation in genBloomFilterIfNeeded method
spark/src/main/scala/ai/chronon/spark/LabelJoin.scala	Updated collection conversions in computeRange and computelabelParts methods

Possibly related PRs

• chore: separate column predicates from partition filters #149: Changes to Join class filtering conditions
• chore: small cleanup of TableUtils #153: Modifications to TableUtils class utility functions

Suggested Reviewers

• nikhil-zlai
• piyush-zlai
• chewy-zlai

Poem

Farewell, implicit classes so neat,
Scala and Java collections now meet
With .toMap.asJava we dance
Refactoring code with elegant stance 🌟
A symphony of type conversion's art! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 6d3b6ca and bcdfca5.

📒 Files selected for processing (4)

• spark/src/main/scala/ai/chronon/spark/Extensions.scala (0 hunks)
• spark/src/main/scala/ai/chronon/spark/Join.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/JoinUtils.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/LabelJoin.scala (2 hunks)

💤 Files with no reviewable changes (1)

• spark/src/main/scala/ai/chronon/spark/Extensions.scala

🔇 Additional comments (4)

spark/src/main/scala/ai/chronon/spark/LabelJoin.scala (2)

159-164: Consistent conversion approach.

Switching from .toJMap to .toMap.asJava is more idiomatic. Looks good.

---

247-247: Maintain clarity in optional usage.

Using toMap.asJava inside Option(...) is coherent. No issues noted.

spark/src/main/scala/ai/chronon/spark/JoinUtils.scala (1)

307-313: Collections conversion alignment.

This replacement from .toJMap to .toMap.asJava is consistent with the rest. Good practice.

spark/src/main/scala/ai/chronon/spark/Join.scala (1)

277-282: Bloom filter creation.

Using .toMap.asJava ensures uniform collection handling. Nicely done.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tchow-zlai]

unused seems like.