Revert 153 tchow/remove deprecated code #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary
- Removing deprecated method
- A couple partition methods are used only in unit tests, going to move
them out of the main `TableUtils` so that we don't have to generally
support them.
## Checklist
- [x] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced a new utility class, `TableTestUtils`, for enhanced
partition management in Spark SQL.
- Added methods for dropping partitions and partition ranges in the new
utility class.
- **Bug Fixes**
- Improved error handling for partition insertion and schema validation
in tests.
- **Refactor**
- Removed deprecated methods related to partition management.
- Updated test classes to utilize the new `TableTestUtils` for clarity
and specificity.
- **Style**
- Enhanced readability and formatting in test cases and schema
declarations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"tchow/bq-support-4","parentHead":"abd251cdadcea8c01fe11b8025358a275cc3eb38","parentPull":148,"trunk":"main"}
```
-->
This reverts commit 5039437.
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces comprehensive changes to the Chronon project's Google Cloud Platform (GCP) integration, focusing on dependency management, BigQuery and Google Cloud Storage (GCS) format providers, and test infrastructure. The modifications enhance the project's ability to interact with cloud storage and data services by adding new classes, updating build configurations, and implementing robust testing mechanisms for cloud-based data operations. Changes
Sequence DiagramsequenceDiagram
participant User
participant GCPFormatProvider
participant BQuery
participant GCS
participant SparkSession
User->>GCPFormatProvider: readFormat(tableName)
GCPFormatProvider->>SparkSession: Get table metadata
alt BigQuery Provider
GCPFormatProvider->>BQuery: Create BQuery instance
else GCS Provider
GCPFormatProvider->>GCS: Create GCS instance
else Default
GCPFormatProvider->>SparkSession: Return Hive format
end
Possibly related PRs
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Chores