Skip to content

include note about java version #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

include note about java version #104

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8177fde
include note about java version
ken-zlai Dec 3, 2024
b4ec8ea
link to devnotes
ken-zlai Dec 4, 2024
abf7325
Merge branch 'main' into java-version
ken-zlai Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docker-init/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

This directory holds code to setup docker containers for dynamoDB, a spark master, and a spark worker. It also creates a container which contains a parquet table with example data containing anomolies. To start, run:

> [!NOTE]
> Make sure you have `docker>=20.10` installed.
> **Note**
> Make sure you have `docker >= 20.10` installed.
> Make sure you have `jdk version 11 or 17` installed.
Copy link
Collaborator

@tchow-zlai tchow-zlai Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just fix it to what we have in the dev notes? https://github.com/zipline-ai/chronon/blob/main/devnotes.md#install-appropriate-java-scala-and-python-versions

Copy link
Contributor Author

@ken-zlai ken-zlai Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've linked it to the devnotes section


```bash
Expand Down