Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI stuff #1031

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Update CI stuff #1031

merged 7 commits into from
Feb 12, 2025

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Feb 12, 2025

I'm mainly updating the CI stuff, aligning with other ZIO projects.

I updated the example app because I though it was the cause of compilation issue with Scala3, but it was something else.
At least, it's done 🙂

@guizmaii guizmaii requested review from mijicd and a team as code owners February 12, 2025 07:34
@guizmaii guizmaii force-pushed the update_ci branch 4 times, most recently from 6c592ba to f8fdbee Compare February 12, 2025 07:46
@@ -2,12 +2,12 @@ name: Release Drafter

on:
push:
branches: ['master']
branches: ['main']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new branch, please remove the old master and adjust gh-pages if necessary.

addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.4")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.4")
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.7")
//addSbtPlugin("org.typelevel" % "sbt-tpolecat" % "0.5.2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//addSbtPlugin("org.typelevel" % "sbt-tpolecat" % "0.5.2")

@guizmaii guizmaii marked this pull request as draft February 12, 2025 10:38
@guizmaii guizmaii self-assigned this Feb 12, 2025
@guizmaii
Copy link
Member Author

@mijicd Ready for review

@guizmaii guizmaii marked this pull request as ready for review February 12, 2025 12:11
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

smurf

@mijicd mijicd merged commit 5a1b3f2 into main Feb 12, 2025
12 checks passed
@mijicd mijicd deleted the update_ci branch February 12, 2025 12:43
hcwilhelm pushed a commit to hcwilhelm/zio-redis that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants