Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fromZSchemaMulti #2996

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Fix fromZSchemaMulti #2996

merged 4 commits into from
Aug 2, 2024

Conversation

pawelsadlo
Copy link
Contributor

/claim #2916

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

algora-pbc bot commented Aug 1, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.60%. Comparing base (e9f1c02) to head (38584e5).
Report is 22 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
+ Coverage   64.78%   65.60%   +0.81%     
==========================================
  Files         157      156       -1     
  Lines        9395     9604     +209     
  Branches     1743     1740       -3     
==========================================
+ Hits         6087     6301     +214     
+ Misses       3308     3303       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes
Copy link
Member

jdegoes commented Aug 1, 2024

There needs to exist, at minimum, a new failing test case that, when this patch is applied, makes the test case succeed.

(cherry picked from commit 4fe9987)
@pawelsadlo
Copy link
Contributor Author

@jdegoes added test

@987Nabil 987Nabil merged commit 0392228 into zio:main Aug 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants