Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add middlewares to forward header and ensure the existence of a header #2808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add middlewares to forward header and ensure the existence of a header #2808

wants to merge 2 commits into from

Conversation

987Nabil
Copy link
Contributor

No description provided.

@987Nabil
Copy link
Contributor Author

@jdegoes this PR has mainly microservice architecture in mind. But I am not sure about the header forwarding. This solution uses fiber refs, but it could be as well using Env and the context providing middleware. The trade off is, does one like the requirement of forwarded headers be explicit in the type or not? I am not sure what I prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes Awaiting requested review from jdegoes jdegoes is a code owner

@vigoo vigoo Awaiting requested review from vigoo vigoo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@987Nabil