Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emptyStringIsValue in StringSchemaCodec is missing a case for Schena.Transform #3417

Closed
987Nabil opened this issue Mar 19, 2025 · 4 comments · Fixed by #3418
Closed

emptyStringIsValue in StringSchemaCodec is missing a case for Schena.Transform #3417

987Nabil opened this issue Mar 19, 2025 · 4 comments · Fixed by #3418
Labels
💎 Bounty bug Something isn't working 💰 Rewarded

Comments

@987Nabil
Copy link
Contributor

It throws a match error, if you have a schema like Schema[String].transform for a query/header param
@987Nabil 987Nabil added the bug Something isn't working label Mar 19, 2025
987Nabil added a commit to 987Nabil/zio-http that referenced this issue Mar 19, 2025
@987Nabil
Handle Schema.Transform in StringSchemaCodec.emptyStringIsValue
80d3ab0 
(zio#3417)
@987Nabil 987Nabil mentioned this issue Mar 19, 2025
Merged
@jdegoes
Copy link
Member

jdegoes commented Mar 20, 2025

/bounty $50

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 20, 2025 •
edited
Loading

💎 $50 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #3417 with your implementation plan
  2. Submit work: Create a pull request including /claim #3417 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #3418

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 20, 2025

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit that referenced this issue Mar 20, 2025
@987Nabil
Handle Schema.Transform in StringSchemaCodec.emptyStringIsValue (#…
4d755ad 
…3418)

* Handle `Schema.Transform` in `StringSchemaCodec.emptyStringIsValue`

(#3417)

* Mark test as flaky
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 20, 2025

🎉🎈 @987Nabil has been awarded $50! 🎈🎊

mhodovaniuk pushed a commit to mhodovaniuk/zio-http that referenced this issue Mar 28, 2025
@987Nabil @mhodovaniuk
Handle Schema.Transform in StringSchemaCodec.emptyStringIsValue (z…
cca0f71 
…io#3418)

* Handle `Schema.Transform` in `StringSchemaCodec.emptyStringIsValue`

(zio#3417)

* Mark test as flaky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty bug Something isn't working 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle Schema.Transform in StringSchemaCodec.emptyStringIsValue 987Nabil/zio-http
2 participants
@jdegoes @987Nabil