Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Request#addCookie Method #3365

Closed
khajavi opened this issue Feb 27, 2025 · 5 comments · Fixed by #3410
Closed

Missing Request#addCookie Method #3365

khajavi opened this issue Feb 27, 2025 · 5 comments · Fixed by #3410
Labels
💎 Bounty 💰 Rewarded

Comments

@khajavi
Copy link
Member

khajavi commented Feb 27, 2025

A Request#addCookie method would create symmetry with Response#addCookie, removing the need for following workaround:

val cookie =
  Cookie.Request(
    name = "sessionId",
    content = "abc123"
  )

val request =
  Request
    .get("http://localhost:8080/profile/me")
    .addHeaders(Headers(Header.Cookie(NonEmptyChunk(cookie))))
@987Nabil
Copy link
Contributor

We should also add addCookies to both Request and Response

987Nabil added a commit to 987Nabil/zio-http that referenced this issue Mar 16, 2025
@987Nabil
Add addCookie and addCookies to Request/Response (zio#3365)
b7fac44
@987Nabil 987Nabil mentioned this issue Mar 16, 2025
Merged
987Nabil added a commit to 987Nabil/zio-http that referenced this issue Mar 16, 2025
@987Nabil
Add addCookie and addCookies to Request/Response (zio#3365)
6296fd4
987Nabil added a commit to 987Nabil/zio-http that referenced this issue Mar 16, 2025
@987Nabil
Add addCookie and addCookies to Request/Response (zio#3365)
0a817f8
@jdegoes
Copy link
Member

jdegoes commented Mar 20, 2025

/bounty $75

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 20, 2025 •
edited
Loading

💎 $75 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #3365 with your implementation plan
  2. Submit work: Create a pull request including /claim #3365 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #3410

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 20, 2025

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit that referenced this issue Mar 20, 2025
@987Nabil
Add addCookie and addCookies to Request/Response (#3365) (#3410)
84f27bf
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 20, 2025

🎉🎈 @987Nabil has been awarded $75! 🎈🎊

mhodovaniuk pushed a commit to mhodovaniuk/zio-http that referenced this issue Mar 28, 2025
@987Nabil @mhodovaniuk
Add addCookie and addCookies to Request/Response (zio#3365) (z…
3dc13dd 
…io#3410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add addCookie and addCookies to Request/Response (#3365) 987Nabil/zio-http
3 participants
@jdegoes @khajavi @987Nabil