Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic ServerSentEvents #2952

Closed
987Nabil opened this issue Jul 9, 2024 · 4 comments · Fixed by #2985
Closed

Generic ServerSentEvents #2952

987Nabil opened this issue Jul 9, 2024 · 4 comments · Fixed by #2985
Labels
💎 Bounty enhancement New feature or request 💰 Rewarded

Comments

@987Nabil
Copy link
Contributor

987Nabil commented Jul 9, 2024

Currently the data of ServerSentEvents is a string. But I think we can make it a generic type that needs a Schema and use HttpContentCodec to encode the data. This should be more user friendly, since users don't need to transform data to strings by themselves.
@987Nabil 987Nabil added the enhancement New feature or request label Jul 9, 2024
@jdegoes
Copy link
Member

jdegoes commented Jul 30, 2024

/bounty $250 but has to be done fast due to final release.

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 30, 2024 •
edited

💎 $250 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #2952 with your implementation plan
  2. Submit work: Create a pull request including /claim #2952 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #2985

987Nabil added a commit to 987Nabil/zio-http that referenced this issue Jul 30, 2024
@987Nabil
Generic ServerSentEvents (zio#2952)
597cebb 
Signed-off-by: Nabil Abdel-Hafeez <[email protected]>
@987Nabil 987Nabil mentioned this issue Jul 30, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 30, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit to 987Nabil/zio-http that referenced this issue Jul 30, 2024
@987Nabil
Generic ServerSentEvents (zio#2952)
480d329
987Nabil added a commit to 987Nabil/zio-http that referenced this issue Jul 30, 2024
@987Nabil
Generic ServerSentEvents (zio#2952)
4f21ce0
987Nabil added a commit to 987Nabil/zio-http that referenced this issue Jul 30, 2024
@987Nabil
Generic ServerSentEvents (zio#2952)
05a0e0b
jdegoes pushed a commit that referenced this issue Aug 2, 2024
@987Nabil
Generic ServerSentEvents (#2952) (#2985)
66d3eea
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Aug 2, 2024

🎉🎈 @987Nabil has been awarded $250! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty enhancement New feature or request 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generic ServerSentEvents (#2952) 987Nabil/zio-http
2 participants
@jdegoes @987Nabil