Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without Implementation doesn't work #1

Open
wheelergames opened this issue Jan 29, 2023 · 7 comments
Open

Without Implementation doesn't work #1

wheelergames opened this issue Jan 29, 2023 · 7 comments

Comments

@wheelergames
Copy link

Hi, someone gave me a post to your page https://zinovik.github.io/digital-board-games/ and it's amazing! Thanks so much for creating it!

It has one minor bug though. When selecting just 'Without Implementaion' it brings back every game in the list, not ones that have no implementation.

Thanks

@zinovik
Copy link
Owner

zinovik commented Jan 29, 2023

Hi and thank you very much for the comment.
It works as it was intended. Maybe it rather has a problem with naming 🤔
The idea of the option is to also show the games without the implementation for the services chosen above.
I am not sure anybody wants to get the list of the games without implementation anywhere at all 🤔

@wheelergames
Copy link
Author

wheelergames commented Jan 29, 2023 via email

@zinovik
Copy link
Owner

zinovik commented Jan 29, 2023

Hm. I will think what I can do with that. But I am not sure BGA correletes with the mobile implementations because it has diferennt kind of users. Maybe, I will rename it.

Where do you get your data from? I found the link for the json, which
appeared to be another of your repos, are you scraping and compiling it
yourself?

Yes. I found every implementation myself and created this JSON manually.

@wheelergames
Copy link
Author

wheelergames commented Jan 30, 2023 via email

@zinovik
Copy link
Owner

zinovik commented Jan 30, 2023

For now, I've renamed these 2 options to make it clear:
All ➡️ Select All
Without Implementation ➡️ Show All Games in the List.

I will think how difficult is to add a new Without Implementation option a little it later ;)

I don't want to criticise it at all, but you are missing some for
sure, like Everdell has mobile apps and i think Steam too.

Thanks! Everdell is added now ;)

Thanks for the sharing the lists of the games. I check the lists like these time to time to try to keep my list more or less up to date.

@wheelergames
Copy link
Author

wheelergames commented Jan 30, 2023 via email

@zinovik
Copy link
Owner

zinovik commented Mar 15, 2023

One more renaming to make it a bit more clear:
Show All Games in the List ➡️ Also, show the games without implementation on selected sites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants