Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutation closing #702

Merged
merged 3 commits into from
Jul 27, 2020

Conversation

micimize
Copy link
Collaborator

Closes #700 by not closing mutations after callbacks run

changes published as 4.0.0-alpha.3@SanjiKir lmk if it fixes things for you

Fixes / Enhancements

  • don't close ObservableQuery after callbacks fire while side effects are pending
  • update graphql_flutter/example to work with most recent flutter

@SanjiKir
Copy link

@micimize Works like a charm! Thanks man!

@micimize micimize merged commit 05fdd0c into zino-hofmann:modularization Jul 27, 2020
@micimize micimize deleted the fix_mutation_closing branch July 27, 2020 18:30
@HofmannZ
Copy link
Member

HofmannZ commented Oct 7, 2020

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HofmannZ
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants