Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop Link layer in favor of package:gql_link and package:gql_exec #564

Merged
merged 1 commit into from
May 9, 2020

Conversation

klavs
Copy link
Collaborator

@klavs klavs commented Feb 16, 2020

BREAKING CHANGE: Link layer is now implemented via package:gql_link and package:gql_exec

First steps towards #563

  • drop Link layer in favor of package:gql_link and package:gql_exec
  • examples not updated as they are already outdated
  • docs to be updated when more changes come in
  • the surface between client and link could still get some love (better error handling)
  • this change is probably not bug-free and could be improved later PRs against modularization branch
  • the package:gql_*_link family is not up to par with the code removed from here, but it'll be done before modularization branch is merged. Also, that's the point of modularization - the Link layer can be improved independently from the client.

BREAKING CHANGE: Link layer is now implemented via package:gql_link and package:gql_exec
@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #564 into modularization will decrease coverage by 10.66%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           modularization     #564       +/-   ##
===================================================
- Coverage           59.89%   49.22%   -10.67%     
===================================================
  Files                  38       19       -19     
  Lines                1471      772      -699     
===================================================
- Hits                  881      380      -501     
+ Misses                590      392      -198
Flag Coverage Δ
#graphql_client 50.33% <66.66%> (-10.36%) ⬇️
#graphql_flutter 22.58% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...raphql/lib/src/exceptions/operation_exception.dart 28.57% <ø> (ø) ⬆️
packages/graphql/lib/src/core/query_options.dart 43.43% <ø> (-1.02%) ⬇️
packages/graphql/lib/src/graphql_client.dart 75% <0%> (ø) ⬆️
...kages/graphql/lib/src/core/raw_operation_data.dart 71.42% <50%> (-6.84%) ⬇️
packages/graphql/lib/src/core/query_manager.dart 54.31% <76.19%> (+3%) ⬆️
...ckages/graphql/lib/src/utilities/get_from_ast.dart 50% <0%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15347c3...2e491a7. Read the comment docs.

@micimize micimize mentioned this pull request Apr 19, 2020
5 tasks
@micimize micimize merged commit d711647 into zino-hofmann:modularization May 9, 2020
@HofmannZ
Copy link
Member

HofmannZ commented Oct 7, 2020

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HofmannZ
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants