Address null check error and prevent duplicate events on socket reconnect #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsham
changed the title
vincenzopalazzo
previously approved these changes
Mar 31, 2024
|
please can fix the Ci ? :) I think it is missing a simple |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 64.83% 64.61% -0.23%
==========================================
Files 41 41
Lines 1732 1718 -14
==========================================
- Hits 1123 1110 -13
+ Misses 609 608 -1 ☔ View full report in Codecov by Sentry. |
|
Some tests are failing because of this PR (#1394), which did not have all necessary checks run for it. |
|
@vincenzopalazzo can you merge this please? |
Rebase the PR on top of the current master in this way we can verify that the Ci is happy, thanks |
**Fixes** - Removed unnecessary null checks(!) on SocketChannel instance in SocketClient onConnectionLost() method which cause an error when client cannot connect (zino-hofmann#1379). this prevents reconnecting when there is a working connection later.
Resolved an issue in WebSocketClient where multiple listeners were added to `waitForConnectedState` when socket reconnects after subscription been requtesed with disconnected socket, causing duplicate events to be received by subscriptions.
… before writing to cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
onConnectionLost()method which cause an error when client cannot connect (Null check operator used on a null value in SocketClient.onConnectionLost #1379). this prevents reconnecting when there is a working connection later.waitForConnectedStatewhen socket reconnects after subscription been requtesed with disconnected socket, causing duplicate events to be received by subscriptions (Subscription will receive same event in some edge case #989) (thanks to @stardarLeung).fetchMorewhere results were not added to the stream whenfetchMoreOptions.updateQueryreturned null.