🥗 Marketplace: The Square Test is failings on Dependabot PRs
#2095
Conversation
- #1500 - #2034 I'm not quite sure what the reason is; and didn't want to tinker too much since @rosschapman and @anaulin know more about how this works. My current theory is we need to update the [`Dependabot` Secrets](https://github.com/zinc-collective/convene/settings/secrets/dependabot) with the Square credentials and Locations that they set up last Wednesday. I think we used the [email protected] account, but the phone number for that is not tied to the Google Voice number for [email protected]; so I wasn't able to log in. I did log in as [email protected]; and there are credentials there but I am not brainy enough to figure out if that's the right account or not. Anyway, to unbreak the tests for Dependabot rolling again; I am ditching the `with_square` trait in the `marketplace` in the `buying_products_spec.rb`. We'll probably want to write a `marketplace/order_notifications/with_square_spec.rb` that tests that use case more explicitely, including assertions against the Square API that confirm we get the data in the PoS right.
zspencer
changed the title
Marketplace: The Square Test is failings on CIMarketplace: The Square Test is failings on Dependabot PRs
|
@zspencer did you double-check Dependabot's secrets for Square? When I was working on this with Ross last Wednesday, I didn't touch those at all, since I was planning to see if our changes in the "regular" CI were working first. |
|
Ah, I read now your detailed PR description and I see that you didn't check those secrets. I'll look into it. |
|
I re-set the Dependabot secret values or One of the Dependabot PRs is now green, and the rest are re-running tests, so I think we don't need this change anymore. |
|
And now some of the Dependabot PRs are failing CI because they can't install the |
|
Yea, those Stripe issues are... annoying. I would love it if we had a cached version of the CLI on our own S3 bucket that we automatically updated periodically (say, monthly?) so that we don't have to deal with Stripe's CDN blocking Github Actions servers. Since you updated the Dependabot Secrets, I am going to close this out! Thank you!!! |
zspencer
deleted the
marketplace/tests-are-failing-and-i-cant-quite-get-why
branch
Marketplace:SellerreceivesOrderin theirSquarePoint of Sale #1500Marketplace: End-to-end testSellerreceivesOrder inSquare` Point of Sale #2034Tests seem to be broken when on PRs that come in from Dependabot.
I'm not quite sure what the reason is; and didn't want to tinker too much since @rosschapman and @anaulin know more about how this works.
My current theory is we need to update the
DependabotSecrets with the Square credentials and Locations that they set up last Wednesday.I think we used the [email protected] account, but the phone number for that is not tied to the Google Voice number for [email protected]; so I wasn't able to log in.
I did log in as [email protected]; and there are credentials there but I am not brainy enough to figure out if that's the right account or not.
Anyway, to unbreak the tests for Dependabot rolling again; I am ditching the
with_squaretrait in themarketplacein thebuying_products_spec.rb. We'll probably want to write amarketplace/order_notifications/with_square_spec.rbthat tests that use case more explicitely, including assertions against the Square API that confirm we get the data in the PoS right.