Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Gizmos" section of the Section (aka room) configuration view #1506

Merged
merged 4 commits into from
May 26, 2023

Conversation

anaulin
Copy link
Member

@anaulin anaulin commented May 25, 2023

This PR:

  • unifies the Gizmos section into one card
  • changes the dropdown to require people to select a furniture kind, so that they don't add things by accident
  • enforces that a furniture_kind value is set, and shows the error in the UI if there is one

It would be nice to improve this further so that it is not possible to submit the "add new" form without a valid type selected.

Before

image

After

image

Error message on failed "add gizmo" action

image

@anaulin anaulin requested review from a team May 25, 2023 02:21
@anaulin anaulin force-pushed the au/tweak-configure-room branch from f122eaa to 7d2a87c Compare May 25, 2023 02:24
@anaulin anaulin force-pushed the au/tweak-configure-room branch from 7d2a87c to 54c477a Compare May 25, 2023 02:26
Copy link
Member

@zspencer zspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@anaulin anaulin merged commit 5b2fd6b into main May 26, 2023
@anaulin anaulin deleted the au/tweak-configure-room branch May 26, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants