Update rank test and comments

zillow · Sep 4, 2024 · 7081e51 · 7081e51
1 parent 087d8e9
commit 7081e51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/quantile_forest/_quantile_forest_fast.pyx b/quantile_forest/_quantile_forest_fast.pyx
@@ -885,6 +885,7 @@ cdef class QuantileForest:
                         if train_indices[k].size() == 0:
                             continue
 
+                        # Clear list of training target values.
                         leaf_samples.clear()
 
                         # Get training target values associated with indices.

diff --git a/quantile_forest/tests/test_quantile_forest.py b/quantile_forest/tests/test_quantile_forest.py
@@ -680,6 +680,7 @@ def check_quantile_ranks(name):
     assert y_ranks.shape == (X_test.shape[0], 2)
     assert np.all(y_ranks >= 0)
     assert np.all(y_ranks <= 1)
+    assert np.all(y_ranks[:, 0] < y_ranks[:, 1])
 
 
 @pytest.mark.parametrize("name", FOREST_REGRESSORS)