enable refine for FAISS HNSW indices by default, if available#932
Conversation
|
@alexanderguzhva 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
a81e60e to
3c9993f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
=========================================
+ Coverage 0 74.21% +74.21%
=========================================
Files 0 82 +82
Lines 0 6422 +6422
=========================================
+ Hits 0 4766 +4766
- Misses 0 1656 +1656 |
src/index/hnsw/faiss_hnsw_config.h
Outdated
| .set_default(1) | ||
| .set_range(1, std::numeric_limits<CFG_FLOAT::value_type>::max()) | ||
| .for_search(); | ||
| .for_search() |
There was a problem hiding this comment.
removed .for_range_search(). Technically, range_k is applicable only for the search, neither range_search, not iterator.
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
3c9993f to
f832c3f
Compare
|
/kind improvement |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.