Skip to content

Add more comments and uts for #353#358

Merged
sre-ci-robot merged 1 commit intozilliztech:mainfrom
chasingegg:topk-second
Jan 22, 2024
Merged

Add more comments and uts for #353#358
sre-ci-robot merged 1 commit intozilliztech:mainfrom
chasingegg:topk-second

Conversation

@chasingegg
Copy link
Collaborator

@chasingegg chasingegg commented Jan 22, 2024

Add uts for both non-filter and filter cases.

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

@chasingegg: The label(s) kind/improvements cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind improvements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Jan 22, 2024

@chasingegg 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@chasingegg
Copy link
Collaborator Author

/kind improvement

@alexanderguzhva
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 170e88e into zilliztech:main Jan 22, 2024
@chasingegg chasingegg deleted the topk-second branch January 23, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants