Skip to content

fix(ci): enforce legacy docs/ gate in Lint workflow#4

Closed
zijiexia wants to merge 3 commits into
mainfrom
fix/docs-gate-ci-enforcement
Closed

fix(ci): enforce legacy docs/ gate in Lint workflow#4
zijiexia wants to merge 3 commits into
mainfrom
fix/docs-gate-ci-enforcement

Conversation

@zijiexia
Copy link
Copy Markdown
Owner

Summary

Why

Without a working CI gate, the rule was only enforced for contributors who had pre-commit installed; everyone else (or anyone using --no-verify) bypassed it silently.

Test plan

  • Static: actionlint .github/workflows/lint.yml reports no new findings (one pre-existing setup-python@v4 warning unrelated to this PR).
  • Local simulation against main with a probe commit touching docs/references/environment_variables.md → step exits 1 and prints the legacy-docs violation.
  • Same simulation with docs/conf.py (allowlist) → exits 0.
  • Same simulation with python/sglang/srt/__init__.py → exits 0.
  • Real CI on this PR: the new step should fail on any PR touching non-allowlisted docs/ files, pass otherwise.

🤖 Generated with Claude Code

@zijiexia
Copy link
Copy Markdown
Owner Author

Superseded by upstream PR sgl-project#26322 — this PR was opened against my own fork by mistake.

@zijiexia zijiexia closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant