Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize inlay hints #948

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

Techatrix
Copy link
Member

This data has been produced by sending 66 inlay hint requests across AstGen.zig.

total time time per request speedup compared to master 🚀
debug-master 41730ms 632ms -
debug-pr 582ms 9.82ms 71.7x
safe-master 5221ms 79ms -
safe-pr 105ms 1.59ms 49.7x
small-master 7581ms 115ms -
small-pr 124ms 1.88ms 61.1x
fast-master 3452ms 52ms -
fast-pr 95ms 1.44ms 36.3x

I've also added some helper function in Ast.zig for iterating over node children and finding nodes that contain a certain source range. This could be useful for implementing ranged semantic tokens.

@SuperAuguste SuperAuguste added the pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!) label Feb 1, 2023
Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization, thanks! :)

@SuperAuguste SuperAuguste merged commit 7b3cc1d into zigtools:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants