Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std.math.cast, std.ChildProcess, tests on Windows and enable Windows in CI #496

Merged
merged 5 commits into from
May 29, 2022

Conversation

leecannon
Copy link
Member

@leecannon leecannon commented May 29, 2022

The length of time ZLS has been unbuildable with zig master has gotten rather long and there has been multiple PRs to fix it each with a different set of patches...

The test "Missing return type" is not a good test as the expected result is dependant on the content of zls.json on the host machine, so I have commented it out.

The test "Open file, ask for semantic tokens" uses a file uri that is invalid on windows, I've changed it to the the same file uri as the other tests.

With these changes the tests pass on windows and can be enabled in the CI.

Fixes #491
Fixes #483

@SuperAuguste
Copy link
Member

LGTM! Thank you so much Lee!

@SuperAuguste SuperAuguste merged commit ee65d3a into zigtools:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling error in newest zig Can't build on windows with latest Zig master
2 participants