Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bugfixes #1328

Merged
merged 3 commits into from
Jul 16, 2023
Merged

More bugfixes #1328

merged 3 commits into from
Jul 16, 2023

Conversation

FnControlOption
Copy link
Contributor

@FnControlOption FnControlOption commented Jul 16, 2023

Fix snippets of aliased functions

Closes #1327

Commit 53b40b3 from #1319 has broken snippet insertion for aliased functions.

Before that commit completion of std.ArrayHashMap results in std.ArrayHashMap(comptime K: type, comptime V: type, comptime Context: type, comptime store_hash: bool) after that commit it results in std.ArrayHashMap.

Show //! doc comments in hover and completions

Closes #304

In Something.zig:

//! top level comment

/// inner comment
a: i32

In main.zig:

const Something = @import("Something.zig");
pub fn main() void {
  const some = Something { .a = 2 }; // Something has no documentation
  some.a; // Has top level documentation and inner documentation 
}

(#308 removed the top level comment for members)

Make Go to Definition fully resolve const Foo = @import("Foo.zig")

Also fix broken Go to Declaration caused by Server API redesign in #1311

Closes #322

const std = @import("std");
const fs = std.fs;

Consider clicking on the .fs, this opens zig/lib/std/std.zig to a line that says const fs = @import("fs.zig");.

The request here is to make it so that when the definition being goto'd is an @import("file.zig");, open file.zig instead.

@FnControlOption FnControlOption marked this pull request as draft July 16, 2023 13:52
@FnControlOption FnControlOption changed the title Fix snippets of aliased functions More bugfixes Jul 16, 2023
@leecannon leecannon enabled auto-merge (rebase) July 16, 2023 17:13
@leecannon leecannon merged commit 2ad3823 into zigtools:master Jul 16, 2023
@FnControlOption FnControlOption deleted the alias branch July 16, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants