-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize document symbols #1050
Merged
SuperAuguste
merged 4 commits into
zigtools:master
from
Techatrix:optimize-document-symbols
Mar 12, 2023
Merged
Optimize document symbols #1050
SuperAuguste
merged 4 commits into
zigtools:master
from
Techatrix:optimize-document-symbols
Mar 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techatrix
added
the
pr:fuzz
Attach to a PR to start fuzzing / continually fuzz (please do this before merging!)
label
Mar 11, 2023
New crash here: https://fuzzing.zigtools.org/group/2e68a9b93841dc6558c591dc227c0dd9 Here's an extract:
|
SuperAuguste
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New errors unrelated to this PR; LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've applied the same optimization that I did on folding ranges in #954 to document symbols.
Generating document symbols for Sema.zig with a ReleaseFast build went from 415ms to 5.3ms which is a 98.7% reduction.
The information on some document symbol should also be slightly improved.
One step towards resolving #1046