Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new module cli arguments #1019

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

leecannon
Copy link
Member

@leecannon leecannon commented Feb 22, 2023

Changes the build runner arguments to match new module cli arguments: ziglang/zig#14664

@llogick
Copy link
Contributor

llogick commented Feb 22, 2023

You have to consider that config.zig_exe's version might be pre --mod supporting.

@leecannon
Copy link
Member Author

oh yea :(

@leecannon
Copy link
Member Author

leecannon commented Feb 22, 2023

So this brings up a similar question as here, how seriously do we take ensuring that zls master can be used with (not compiled with) previous versions of zig.

Do we just recommend people to use tagged commits/releases for the matching zig release or do we keep bending over backward?

In this case its not that bad as we already run zig env so we can just capture the version and do some semantic comparison to pass the right module arguments, but im thinking its time we start considering what we want to do going forward as features like #1000 are going to have to be selectively disabled based on zig version and the version we check for is going to change every time there is a breaking language change that affects ast-gen.

@leecannon leecannon added the pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!) label Feb 22, 2023
@leecannon leecannon marked this pull request as draft February 22, 2023 23:47
@leecannon leecannon removed the pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!) label Feb 22, 2023
@leecannon leecannon added the pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!) label Feb 23, 2023
@leecannon
Copy link
Member Author

The latest commit grabs the runtime zig version from zig env and holds onto it, this is then used to send the correct module cli arguments to the buildrunner.

@leecannon leecannon marked this pull request as ready for review February 23, 2023 00:05
@jakeweary
Copy link

Seems like 0.11.0-dev.1782+b52be973d is not the exact version where --pkg-* paremeters were removed?
The PR doesn't work on 0.11.0-dev.1718+2737dce84.

Those who want to use the PR already, update your Zig again just in case.

@leecannon
Copy link
Member Author

@thepheer fixed

Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1020 is still pending but this LGTM.

@SuperAuguste SuperAuguste merged commit 5ede46f into zigtools:master Feb 23, 2023
@leecannon leecannon deleted the new_module_cli branch February 23, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants