Skip to content

Conversation

@puddly
Copy link
Contributor

@puddly puddly commented Oct 28, 2025

The previous script I was using for this task (TODO: clean it up and move it here to be run by CI) had a bug and missed diagnostics JSON present in the issue body, picking up only those in comments.

Over half are Tuya devices.

@puddly puddly force-pushed the puddly/diagnostics-import-20251028 branch from 8c0999d to 70c7843 Compare October 31, 2025 22:33
@puddly
Copy link
Contributor Author

puddly commented Oct 31, 2025

The last commit is due to a failure here:

$ python -m tools.regenerate_diagnostics tests/data/devices/tze200-a7sghmms-ts0601.json

For some reason, the cluster handler-specific initialization code did not run. The cluster handler computed something that realistically should be handled by the entity so I ported the code over into there. This has the benefit of now allowing the summation formatting to change at runtime.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (76550e0) to head (70c7843).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #557      +/-   ##
==========================================
+ Coverage   96.95%   96.99%   +0.04%     
==========================================
  Files          63       63              
  Lines       10534    10543       +9     
==========================================
+ Hits        10213    10226      +13     
+ Misses        321      317       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant