[BREAKING CHANGE] Phillips Hue remote manufacturer specific cluster handling #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Adminiuga I changed the triggers to make these what we use since they are more robust. Should we mark this as a breaking change in HA since if anyone was using the old ones they will no longer work? |
|
Yes, should be marked as breaking then. Would it break all device triggers or only hue ones |
|
Just these 2 remotes |
|
Maybe still should mark it as breaking but with limited scope for these two remotes. |
|
@Adminiuga think if I merge this and cut a release that we can pull this and the corresponding HA change into the beta? Or should we wait? |
|
Since this is a breaking change, maybe should wait a bit |
dmulcahey
force-pushed
the
dm/phillips-manufacturer-specific
branch
from
9c77a92 to
bdcea51
Compare
dmulcahey
force-pushed
the
dm/phillips-manufacturer-specific
branch
from
bdcea51 to
03a9c48
Compare
dmulcahey
changed the title
This was referenced Jul 6, 2020
Adminiuga
reviewed
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for 4 actions per button: press, hold, short release and long release. It needs home-assistant/core#37172 in order to function.
Fixes: #86
Things still needed: