Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Saswell (Tuya) TRVs to v2 #3772

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

prairiesnpr
Copy link
Collaborator

Proposed change

This converts the Saswell TRVs to v2. This does introduce a duplicate TuyaThermostatV2, but I intend to consolidate all TRVs to tuya_trv.py so this will resolve itself in a follow-on PR.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (d9481d3) to head (60ca6da).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/tuya/tuya_trv.py 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3772      +/-   ##
==========================================
+ Coverage   90.40%   90.74%   +0.34%     
==========================================
  Files         320      320              
  Lines       10490    10427      -63     
==========================================
- Hits         9483     9462      -21     
+ Misses       1007      965      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants