-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Clipsal Dimmer and 2A Switch quirk and entities #3615
base: dev
Are you sure you want to change the base?
Added Clipsal Dimmer and 2A Switch quirk and entities #3615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3615 +/- ##
=======================================
Coverage 89.85% 89.86%
=======================================
Files 321 322 +1
Lines 10374 10380 +6
=======================================
+ Hits 9322 9328 +6
Misses 1052 1052 ☔ View full report in Codecov by Sentry. |
Nice to see more Schneider Electric devices improvements! @TheJulianJES will probably want to review this one, but I know from the feedback on another issue that "Entity names should start with a capital letter, the rest of the words are lower case" (see comment here #3575 (comment)). |
Also, I'm wondering, considering that Ballast/MinLevel and Ballast/MaxLevel are standard Zigbee attributes, is there any reason why they are not automatically exposed as home assistant entities by ZHA? |
Proposed change
Added Clipsal (Australian branded Schneider Electric) push button dimmer and 2A relay.
Additional information
I also added a missing entity to edit device attributes.
Checklist
pre-commit
checks pass / the code has been formatted using Black