Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Clipsal Dimmer and 2A Switch quirk and entities #3615

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

cfulton
Copy link

@cfulton cfulton commented Dec 16, 2024

Proposed change

Added Clipsal (Australian branded Schneider Electric) push button dimmer and 2A relay.

Additional information

I also added a missing entity to edit device attributes.

  • Dimmer: Ballast Control Mode, Min Level, and Max Level.
  • Dimmer and 2A: On Time Reload (Auto turn off after seconds)
  • Dimmer and 2A: Switch Indication

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (979551d) to head (bbd906c).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3615   +/-   ##
=======================================
  Coverage   89.85%   89.86%           
=======================================
  Files         321      322    +1     
  Lines       10374    10380    +6     
=======================================
+ Hits         9322     9328    +6     
  Misses       1052     1052           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uvNikita
Copy link
Contributor

Nice to see more Schneider Electric devices improvements!

@TheJulianJES will probably want to review this one, but I know from the feedback on another issue that "Entity names should start with a capital letter, the rest of the words are lower case" (see comment here #3575 (comment)).

@TheJulianJES TheJulianJES added needs review This PR should be reviewed soon, as it generally looks good. v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. labels Dec 18, 2024
@uvNikita
Copy link
Contributor

Also, I'm wondering, considering that Ballast/MinLevel and Ballast/MaxLevel are standard Zigbee attributes, is there any reason why they are not automatically exposed as home assistant entities by ZHA?

@TheJulianJES TheJulianJES added the waiting for changes Waiting for changes to the PR label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR should be reviewed soon, as it generally looks good. v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. waiting for changes Waiting for changes to the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants