-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Schneider dimmer quirks to v2, add missing models #3529
Conversation
08af788
to
0823029
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3529 +/- ##
==========================================
- Coverage 89.44% 89.43% -0.01%
==========================================
Files 311 311
Lines 10033 10026 -7
==========================================
- Hits 8974 8967 -7
Misses 1059 1059 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
0823029
to
cec8a19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've replaced adds(SESpecific)
with replaces(SESpecific)
, as we want to ensure the original cluster is removed first (and replaced with our custom implementation).
There's some more info in the review comments above.
@TheJulianJES I was just assuming Will keep that in mind for the future, thanks a lot for the review! |
Yeah, we need to get some docs together at some point.. I'm not sure if there's ever any reason to use |
Proposed change
I migrated quirks to v2 and added models other models from the spec.
Looking through the spec docs, they all seem to have equivalent functionality.
The original quirk was missing SEOnOff cluster, so I added it too.
Additional information
Specs:
ZB Spec - Push-button Dimmer - 110422.pdf
ZB Spec - Rotary Dimmer - 110422.pdf
ZB Spec - Relay Switch 10A - 110422.pdf
Checklist
pre-commit
checks pass / the code has been formatted using Black