Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya air sensor _TZE204_ogkdpgy2 variant #3525

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

ktmf01
Copy link
Contributor

@ktmf01 ktmf01 commented Nov 19, 2024

Proposed change

Add Tuya air sensor _TZE204_ogkdpgy2 variant

Additional information

I just received a DCR-LCD Tuya CO2 monitor, and it turned up in Home Assistant as _TZE204_ogkdpgy2. Adding the modified file from this PR as a custom quirk file, the device works fine. Also, as can be deduced from this post, renaming the device works fine for several people, leading me to believe this PR is correct.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@ktmf01 ktmf01 changed the title Add Tuya air sensor Add Tuya air sensor _TZE204_ogkdpgy2 variant variant Add Tuya air sensor _TZE204_ogkdpgy2 variant variant Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (3f4aee0) to head (d497d1f).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3525   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files         311      311           
  Lines       10033    10033           
=======================================
  Hits         8974     8974           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Nov 24, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES changed the title Add Tuya air sensor _TZE204_ogkdpgy2 variant variant Add Tuya air sensor _TZE204_ogkdpgy2 variant Nov 24, 2024
@TheJulianJES TheJulianJES merged commit b2a19f7 into zigpy:dev Nov 24, 2024
9 checks passed
@meneerhenk
Copy link

Thanks.

  • Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants