Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zigpy AttributeDefs for PhilipsBasicCluster #3434

Merged

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Oct 16, 2024

Untested

These changes are still untested.

Proposed change

This converts the PhilipsBasicCluster used for Hue remotes to use the new-style zigpy AttributeDefs.
It also lets the PhilipsWallSwitchBasicCluster inherit from the global PhilipsBasicCluster, so we don't need to define the "philips" attribute twice.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (694f101) to head (75e0be3).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3434      +/-   ##
==========================================
+ Coverage   89.22%   89.25%   +0.02%     
==========================================
  Files         307      307              
  Lines        9870     9869       -1     
==========================================
+ Hits         8807     8809       +2     
+ Misses       1063     1060       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES force-pushed the tjj/attributedefs_philips_remotes branch from 524759b to 75e0be3 Compare October 16, 2024 03:17
@TheJulianJES TheJulianJES merged commit 1a43eab into zigpy:dev Oct 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant