-
Notifications
You must be signed in to change notification settings - Fork 785
Convert Tuya Sensors to TuyaQuirkBuilder format #3425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3425 +/- ##
==========================================
- Coverage 89.40% 89.35% -0.05%
==========================================
Files 308 308
Lines 10021 9978 -43
==========================================
- Hits 8959 8916 -43
Misses 1062 1062 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, all other scales seem fine (just looking through them).
Only for _TZE200_yjjdcqsq
(and the others there) might scale=10
be needed for temperature.
Proposed change
I have a single soil sensor
_TZE284_aao3yzhs
, I was able to test physically with.Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black