Skip to content

Convert Tuya Sensors to TuyaQuirkBuilder format #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2024

Conversation

prairiesnpr
Copy link
Collaborator

@prairiesnpr prairiesnpr commented Oct 15, 2024

Proposed change

I have a single soil sensor _TZE284_aao3yzhs, I was able to test physically with.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (6d029ef) to head (cf5762e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3425      +/-   ##
==========================================
- Coverage   89.40%   89.35%   -0.05%     
==========================================
  Files         308      308              
  Lines       10021     9978      -43     
==========================================
- Hits         8959     8916      -43     
  Misses       1062     1062              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prairiesnpr prairiesnpr marked this pull request as ready for review October 18, 2024 11:32
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Oct 18, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, all other scales seem fine (just looking through them).
Only for _TZE200_yjjdcqsq (and the others there) might scale=10 be needed for temperature.

@TheJulianJES TheJulianJES merged commit 9923e5e into zigpy:dev Oct 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants