-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya TS130F _TZ3000_qqdbccb3
curtain roller
#3380
Conversation
This PR includes a new signature for the Zemismart curtain switch with reference WN2-EC1E because the current one doesn't work for this device. Signed-off-by: Mario de Frutos Dieguez <[email protected]>
10fdb36
to
c914de3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3380 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 305 305
Lines 9621 9624 +3
=======================================
+ Hits 8514 8517 +3
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's needed to remove the Identify
cluster in the replacement
block?
I would suggest not to remove.
Signed-off-by: Mario de Frutos <[email protected]>
Yes! You're completely right, I added it to the signature but not to the replacement part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks.
_TZ3000_qqdbccb3
curtain roller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ethervoid and @javicalle!
Proposed change
This PR includes a new signature for the Zemismart curtain switch with reference WN2-EC1E because the current one doesn't work for this device.
Basically is a new signature for the device already present but this one has a different signature.
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black