Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya TS130F _TZ3000_qqdbccb3 curtain roller #3380

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

ethervoid
Copy link
Contributor

@ethervoid ethervoid commented Sep 22, 2024

Proposed change

This PR includes a new signature for the Zemismart curtain switch with reference WN2-EC1E because the current one doesn't work for this device.

Basically is a new signature for the device already present but this one has a different signature.

Additional information

signal-2024-09-22-172942_002

signal-2024-09-22-172942_003

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This PR includes a new signature for the Zemismart curtain switch with
reference WN2-EC1E because the current one doesn't work for this device.

Signed-off-by: Mario de Frutos Dieguez <[email protected]>
@ethervoid ethervoid force-pushed the ts130f_zemismart_upgrade branch from 10fdb36 to c914de3 Compare September 22, 2024 15:23
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (d9c9df9) to head (c1eac1c).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3380   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         305      305           
  Lines        9621     9624    +3     
=======================================
+ Hits         8514     8517    +3     
  Misses       1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed to remove the Identify cluster in the replacement block?
I would suggest not to remove.

@javicalle javicalle added the Tuya Request/PR regarding a Tuya device label Sep 24, 2024
@ethervoid
Copy link
Contributor Author

Yes! You're completely right, I added it to the signature but not to the replacement part.

@ethervoid ethervoid requested a review from javicalle September 24, 2024 11:37
Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks.

@TheJulianJES TheJulianJES changed the title Add new signature for Tuya TS130F_TZ3000_qqdbccb3 Add Tuya TS130F _TZ3000_qqdbccb3 curtain roller Sep 24, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ethervoid and @javicalle!

@TheJulianJES TheJulianJES merged commit fafbd71 into zigpy:dev Sep 24, 2024
7 checks passed
@ethervoid ethervoid deleted the ts130f_zemismart_upgrade branch September 25, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants