Add Moes Tuya valve controller _TZE204_d0ypnbvn, _TZE200_d0ypnbvn
#3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue zigpy#3291 Closes issue zigpy#3220 Closes issue zigpy#1335 This device is also known as `_TZE200_d0ypnbvn`, I don't have it handy, but it should work for it. This implement support for valve `_TZE204_d0ypnbvn`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3351 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 305 305
Lines 9621 9621
=======================================
Hits 8514 8514
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
TheJulianJES
changed the title
_TZE204_d0ypnbvn _TZE200_d0ypnbvn
TheJulianJES
changed the title
_TZE204_d0ypnbvn _TZE200_d0ypnbvn_TZE204_d0ypnbvn, _TZE200_d0ypnbvn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This implement support for valve
_TZE204_d0ypnbvn.Additional information
This device is also known as
_TZE200_d0ypnbvn, I don't have it handy, but it should work for it.I haven't added test as the code should already be covered as I only added a device to an existing definition.
Fixes #3291, fixes #3220, fixes #1335.
Checklist
pre-commitchecks pass / the code has been formatted using Black