-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert IKEA Styrbar quirks to v2 quirk #3175
Convert IKEA Styrbar quirks to v2 quirk #3175
Conversation
OnOff and Level looks working OK then doing fast testing. I like V2 quirks its much cleaner !!! |
Ah, yeah. |
…ique` The test does not handle v2 quirks yet and we'll need to see how we want to implement this, as all v2 quirks share the same quirk class. For now, this just removes the `fourbtnremote` from the test.
This is needed for left/right buttons to work properly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3175 +/- ##
==========================================
- Coverage 88.19% 88.17% -0.03%
==========================================
Files 300 300
Lines 9400 9383 -17
==========================================
- Hits 8290 8273 -17
Misses 1110 1110 ☔ View full report in Codecov by Sentry. |
Was updating it from your git and now i getting "scene commands" OK.
Also some users dont like that we is not remember the long press for the release like Open/Close is doing here: |
Ok, thanks. But those aren't regressions, right? So no new bugs introduced with this? |
Codecov project coverage decrease is expected, as the old quirk had quite a few lines and is now fully removed with this. |
I think it was not working OK then we was chaining par/args and it was very much testing for all IKEA controllers then doing that and my memory . . . I dont have any problems then i using them as Light controller with device and group bindings so its working then ZHA is not OK. |
Thanks for fixing and closing my V3 that is out of date now !!! |
Only for information: Dirigeras feed have now updated to 0x02040016 and the quirk is working great and then the new firmware have getting one new private cluster but sadly no group binding is being added like all newer IKEA gen 3 controller is having. Edit: 2 of 4 inn production was loosing there binding to deices and must being redone for working after the upgrade. |
Proposed change
Converts existing IKEA Styrbar quirks to a v2 quirk.
This also adds support for new signatures of the Styrbar, as quirks v2 don't need to match by endpoint/clusters (signature) anymore.
Additional information
The only downside I see is that we use
DoublingPowerConfig2AAACluster
for all versions of the remote, even if it's a "newer signature". I think we should at least change the default to not double for that first, before we merge this.Related PR for that:
Would supersede #3144 if we want to go this route.
The test
test_quirk_device_automation_triggers_unique
also still needs updating that should be done in a separate PR.It doesn't deal properly with v2 quirks.
Checklist
pre-commit
checks pass / the code has been formatted using Black