-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aqara E1 motion sensor support #3163
Conversation
lumi.motion.acn001 Aqara E1 motion sensor RTCGQ15LM https://home.miot-spec.com/s/lumi-acn001
Tested with home assistant core 2024.5.4. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3163 +/- ##
==========================================
+ Coverage 88.14% 88.19% +0.04%
==========================================
Files 299 300 +1
Lines 9389 9400 +11
==========================================
+ Hits 8276 8290 +14
+ Misses 1113 1110 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There are still some changes that should be made before merging this.
I think we can even put the quirk class into the original T1 quirk file to not duplicate the XiaomiManufacturerCluster
. The devices are very similar, too.
@TheJulianJES Please check the new commit |
Thanks! I've also made some more changes and refactored the code a bit. |
Proposed change
lumi.motion.acn001
Aqara E1 motion sensor RTCGQ15LM
https://home.miot-spec.com/s/lumi-acn001
I just borrow it from motion_agl02.
I am not expert in zigbee or zha coding, so there maybe the need for code quality improvements.
But it works in my test for motion, illuminance and battery.
Additional information
Fixes #2189
Checklist
pre-commit
checks pass / the code has been formatted using Black