Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya _TZE200_kyfqmmyl switch variant #2966

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

javicalle
Copy link
Collaborator

@javicalle javicalle commented Feb 4, 2024

New Moes 3 gang switch TS0601 by _TZE200_kyfqmmyl

Proposed change

New TuyaTripleSwitch variation for _TZE200_kyfqmmy

Additional information

Fixes: #2469 (already closed)
Fixes #716

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

New Moes 3 gang switch TS0601 by _TZE200_kyfqmmy
@javicalle javicalle added the Tuya Request/PR regarding a Tuya device label Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab0d248) 87.68% compared to head (438dd0d) 87.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2966   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         297      297           
  Lines        9087     9090    +3     
=======================================
+ Hits         7968     7971    +3     
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!
LGTM if the class name is changed.

zhaquirks/tuya/ts0601_switch.py Outdated Show resolved Hide resolved
@javicalle javicalle added the ready PR should be ready to merge label Feb 10, 2024
@TheJulianJES TheJulianJES changed the title Add TuyaTripleSwitch_var03 to ts0601_switch Add Tuya _TZE200_kyfqmmy switch variant Feb 11, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES changed the title Add Tuya _TZE200_kyfqmmy switch variant Add Tuya _TZE200_kyfqmmy switch variant Feb 11, 2024
@TheJulianJES TheJulianJES changed the title Add Tuya _TZE200_kyfqmmy switch variant Add Tuya _TZE200_kyfqmmyl switch variant Feb 11, 2024
@TheJulianJES TheJulianJES merged commit 3e9b675 into zigpy:dev Feb 11, 2024
14 checks passed
@javicalle javicalle deleted the patch-2 branch March 17, 2024 20:09
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR should be ready to merge Tuya Request/PR regarding a Tuya device
Projects
None yet
2 participants