-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quirk for Schneider Electric NHROTARY/DIMMER/1 #2955
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2955 +/- ##
==========================================
+ Coverage 87.81% 87.85% +0.03%
==========================================
Files 300 301 +1
Lines 9187 9212 +25
==========================================
+ Hits 8068 8093 +25
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
ff45092
to
d959def
Compare
d959def
to
09d5349
Compare
09d5349
to
5844b2d
Compare
Rebased onto upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Should we wait for testing/approval from anyone else?
I think it is good to merge, since this change only exposes new attributes and doesn't change any existing behavior. I would like to test the integration with other HA components on top of this new attribute, and it would be nice to get this merged so I don't have to maintain my own local HA quirk |
The quirk will likely only land in Home Assistant Core 2024.3.0 (betas and newer versions) due to the current release schedule/procedure. |
The wiki can probably be also updated: https://github.com/zigpy/zha-device-handlers/wiki/Schneider-Electric |
Proposed change
Adds support for Schneider Electric NHROTARY/DIMMER/1. The main missing piece of functionality is documented in issue #2798.
Additional information
Builds on #2928, I will rebase this PR once that PR is merged. I didn't want to blindly cherry pick and squash changes from the other PR so that merging them remains easy.
Asking for help from @julienhd to help validate this PR.
Checklist
pre-commit
checks pass / the code has been formatted using Black