Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quirk for Schneider Electric NHROTARY/DIMMER/1 #2955

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

dflemstr
Copy link
Contributor

Proposed change

Adds support for Schneider Electric NHROTARY/DIMMER/1. The main missing piece of functionality is documented in issue #2798.

Additional information

Builds on #2928, I will rebase this PR once that PR is merged. I didn't want to blindly cherry pick and squash changes from the other PR so that merging them remains easy.

Asking for help from @julienhd to help validate this PR.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4c15ef) 87.81% compared to head (b80afde) 87.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2955      +/-   ##
==========================================
+ Coverage   87.81%   87.85%   +0.03%     
==========================================
  Files         300      301       +1     
  Lines        9187     9212      +25     
==========================================
+ Hits         8068     8093      +25     
  Misses       1119     1119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dflemstr dflemstr force-pushed the schneider-dimmers branch 3 times, most recently from ff45092 to d959def Compare February 3, 2024 13:53
@TheJulianJES
Copy link
Collaborator

@dflemstr
Copy link
Contributor Author

Rebased onto upstream dev now

zhaquirks/schneiderelectric/dimmers.py Outdated Show resolved Hide resolved
zhaquirks/schneiderelectric/dimmers.py Outdated Show resolved Hide resolved
@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Feb 15, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
Should we wait for testing/approval from anyone else?

@dflemstr
Copy link
Contributor Author

I think it is good to merge, since this change only exposes new attributes and doesn't change any existing behavior. I would like to test the integration with other HA components on top of this new attribute, and it would be nice to get this merged so I don't have to maintain my own local HA quirk

@TheJulianJES
Copy link
Collaborator

The quirk will likely only land in Home Assistant Core 2024.3.0 (betas and newer versions) due to the current release schedule/procedure.

@TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES merged commit 2a39c07 into zigpy:dev Feb 15, 2024
14 checks passed
@dflemstr dflemstr deleted the schneider-dimmers branch February 15, 2024 22:16
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants