Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another signature for Aqara H1 double switch lumi.switch.n2aeu1 #2863

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

Adds another signature for the Aqara EU double wall-switches.
This is based on the opple_switch.py / XiaomiOpple2ButtonSwitch3 signature.

Additional information

Follow-up to:

Reason why the new model info isn't just added to opple_switch.py quirks is explained here: #2826 (comment)
(So basically to avoid confusion and separate the different devices types better.)

Signature reported here: #2826 (comment) (cc @ehoogend)

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This is based on `XiaomiOpple2ButtonSwitch3`
@TheJulianJES TheJulianJES added the Xiaomi Request/PR regarding a Xiaomi device label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab9f6d8) 87.43% compared to head (4d9ee30) 87.43%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2863   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         290      290           
  Lines        8888     8890    +2     
=======================================
+ Hits         7771     7773    +2     
  Misses       1117     1117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehoogend
Copy link

Thanks for picking this up so quickly @TheJulianJES . LGTM!

@TheJulianJES TheJulianJES merged commit f2a1ce5 into zigpy:dev Dec 27, 2023
14 checks passed
elupus pushed a commit to elupus/zha-device-handlers that referenced this pull request Jan 17, 2024
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Xiaomi Request/PR regarding a Xiaomi device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants