-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Aqara motion sensor erroneous motion events #2779
Fix Aqara motion sensor erroneous motion events #2779
Conversation
LocalDataCluster
for Occupancy
cluster
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2779 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 300 300
Lines 9218 9222 +4
=======================================
+ Hits 8103 8107 +4
Misses 1115 1115 ☔ View full report in Codecov by Sentry. |
Unfortunately, the person who had these issues and was testing this is no longer responding. For anyone else with the Aqara T1 motion sensor who experiences "ghost detections", please test this as a custom quirk and report back if that corrects it. |
The T1 sensor sends wrong occupancy attribute reports roughly every hour.
2cf6736
to
86b91e0
Compare
Works, but I don't want to change it in this PR.
There are fixes for the Aqara T1 motion sensor and Aqara high-precision motion sensor in Home Assistant Core 2024.4.0 (in beta currently). There's nothing for you to change. |
lumi.motion.agl04 does not work after update. Does not detect motion. Never. |
@stast1 Please create a new issue. Also, try re-pairing the sensor. |
home-assistant/core#115027 |
Proposed change
The Aqara T1 motion sensor sends false attribute reports about every hour or so on the
Occupancy
cluster. Just using aLocalDataCluster
doesn't ignore them, so we overridehandle_cluster_general_request
.The same fix is also applied for the Aqara "high-precision" agl04 motion sensor.
This was reported via Discord.
Additional information
We should also consider using a
LocalMotionCluster
for this sensor in the future (like the P1 quirk already does).A 60 second timeout also works for this sensor.
Ideally, we should also figure out if this is needed for the "high-precision" agl04 motion sensor.
-> yes, see home-assistant/core#114129
Checklist
pre-commit
checks pass / the code has been formatted using Black