Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump isort to 5.12.0 in pre-commit config #2147

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Jan 28, 2023

See PyCQA/isort#2077
Fixed by PyCQA/isort#2078 in isort 5.12.0

Will resolve the issue that #2146 runs into (when rebased)

@codecov-commenter
Copy link

Codecov Report

Base: 83.70% // Head: 83.70% // No change to project coverage 👍

Coverage data is based on head (2ab9d98) compared to base (07f38fc).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2147   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files         258      258           
  Lines        8228     8228           
=======================================
  Hits         6887     6887           
  Misses       1341     1341           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheJulianJES TheJulianJES marked this pull request as ready for review January 28, 2023 17:28
@dmulcahey dmulcahey merged commit 8a82aab into zigpy:dev Jan 28, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4032834884

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.702%

Totals Coverage Status
Change from base Build 4019454703: 0.0%
Covered Lines: 6887
Relevant Lines: 8228

💛 - Coveralls

@TheJulianJES TheJulianJES deleted the tjj/bump_isort branch January 28, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants