Merger TS004Fs to EnchantedDevice. #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merger all device classes of TS004f to EnchantedDevice and adding one more found DS. All function is tested after deleting and reset and removing the battery and adding them they is getting the magic function then doing one new joining. All commands looks OK in the log but have not testing the DA then its not changed.
Pull Request Test Coverage Report for Build 3808429182
💛 - Coveralls |
Codecov ReportBase: 83.64% // Head: 83.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #2046 +/- ##
==========================================
+ Coverage 83.64% 83.70% +0.06%
==========================================
Files 249 249
Lines 8024 8017 -7
==========================================
- Hits 6712 6711 -1
+ Misses 1312 1306 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@javicalle Now the most tricky "normal" Zigbee device is migrated and looks working great with your implementation. feliz año nuevo !! |
javicalle
added
the
needs final review
Happy new year to you too!!! |
|
Thanks D(&)J |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merger all device classes of TS004f to
EnchantedDeviceand adding one more found DS. All function is tested after deleting and reset and removing the battery and adding them they is getting the magic function then doing one new joining. All commands looks OK in the log but have not testing the DA then its not changed.Its 2 more new devices that we have working but the user have not confirming they is working OK so not implanted (LIDL pad and the press knob).