Skip to content

TS0601 - _TZE200_bkkmqmyo - Full Support excluding Alarm and its Configuration (#1877)(#1700) #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 11, 2022

Conversation

flaktivated
Copy link
Contributor

Added Support for On-Off Switch.

@coveralls
Copy link

coveralls commented Nov 1, 2022

Pull Request Test Coverage Report for Build 3373490002

  • 30 of 57 (52.63%) changed or added relevant lines in 1 file are covered.
  • 104 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 82.563%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/tuya/ts0601_din_power.py 30 57 52.63%
Files with Coverage Reduction New Missed Lines %
zhaquirks/tuya/init.py 104 71.99%
Totals Coverage Status
Change from base Build 3355517399: -0.2%
Covered Lines: 6269
Relevant Lines: 7593

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Base: 82.77% // Head: 82.56% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (6070f44) compared to base (41fd313).
Patch coverage: 52.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1878      +/-   ##
==========================================
- Coverage   82.77%   82.56%   -0.22%     
==========================================
  Files         243      243              
  Lines        7541     7593      +52     
==========================================
+ Hits         6242     6269      +27     
- Misses       1299     1324      +25     
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601_din_power.py 60.74% <52.63%> (-8.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch Support Added (#1877) TS0601 - _TZE200_bkkmqmyo - Basic Switch Support Power, Voltage and Energy Summation Support(#1877) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch Support Power, Voltage and Energy Summation Support(#1877) TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage and Energy Summation Support(#1877) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage and Energy Summation Support(#1877) TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Frequency and Energy Summation Support(#1877) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Frequency and Energy Summation Support(#1877) TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Frequency, Power Factor and Energy Summation Support(#1877) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Frequency, Power Factor and Energy Summation Support(#1877) TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Current, Frequency, Power Factor and Energy Summation Support(#1877) Nov 1, 2022
@flaktivated
Copy link
Contributor Author

flaktivated commented Nov 1, 2022

Linking PR to existing issue raised:
#1700

Closed duplicate Issue:
#1877

@flaktivated
Copy link
Contributor Author

Testing Evidence:
image
image

@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Current, Frequency, Power Factor and Energy Summation Support(#1877) TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Current, Frequency, Power Factor, Reactive Power, Reactive Power Totals and Energy Delivered/Received Summation Support(#1877) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Basic Switch, Power, Voltage, Current, Frequency, Power Factor, Reactive Power, Reactive Power Totals and Energy Delivered/Received Summation Support(#1877) TS0601 - _TZE200_bkkmqmyo - Full Support (excluding Alarm and its Configuration) (#1877) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Full Support (excluding Alarm and its Configuration) (#1877) TS0601 - _TZE200_bkkmqmyo - Full Support (excluding Alarm and its Configuration) (#1877)(#1700) Nov 1, 2022
@flaktivated flaktivated changed the title TS0601 - _TZE200_bkkmqmyo - Full Support (excluding Alarm and its Configuration) (#1877)(#1700) TS0601 - _TZE200_bkkmqmyo - Full Support excluding Alarm and its Configuration (#1877)(#1700) Nov 1, 2022
…1878)

total_reactive_power is an integer so decimals are rounded during conversion. Moving the formatting to happen at the sensor level.
@dmulcahey
Copy link
Collaborator

@javicalle is this good to go in your opinion?

@javicalle
Copy link
Collaborator

Not too familiar with all the Metering and ElectricalMeasurement but the code looks good to me.

@dmulcahey
Copy link
Collaborator

dmulcahey commented Nov 11, 2022

@flaktivated thanks for the contribution!! @javicalle (@MattWestb as well!) thanks as always for all of the help and support! The community owes you a debt of gratitude for the amount of time you have spent cleaning up after Tuya!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants