Make TS011F plugs inherit EnchantedDevice
#1833
Conversation
There are reports that some Blitzwolf SHP 15 plugs (depending on its version) don't report the On/Off update from the physical device. The `herdsman-converters` lib have 3 implementations for the `TS011F` plugs, 2 of them 'implements' the EnchantedDevice approach: * https://github.com/Koenkk/zigbee-herdsman-converters/blob/96563772e92eb459bf52c10e241c3a725968bcab/devices/tuya.js#L2185 My assumption is that the use of the `EnchantedDevice` cannot be harmful. Also I have not located implementations that could be affected if a device starts to behave in a 'standard' way, **but** there are no guarantees on what will happen and I do not know the scope (of devices) that the change can affect. If the change is considered too risky, I can try to narrow it down to only the devices that have been reported, but I'll need to check how to match 2 compatible signatures and ensure priority is resolved in the desired order: ```python MODEL: "TS011F", vs MODELS_INFO: [("TS011F", "_TZ3000_u5u4cakc")], ```
Pull Request Test Coverage Report for Build 3260856818
💛 - Coveralls |
Codecov ReportBase: 80.06% // Head: 80.06% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #1833 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 240 240
Lines 7455 7455
=======================================
Hits 5969 5969
Misses 1486 1486
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
My experience and is adding it to the class and keep the First out of the TS011F was the LIDL with updated firmware and more is likely cumming. |
|
Does that mean I can delete ts011f_plug.py from my custom_zha_quirks directory? Regards Frank |
Not yet. Sooo, in short: no, but it will be inlcuded in the next HA version. |
|
The updated quirk is in released HA 2022.10.5. So feel free updating HA and also before deleting the "temporary quirk" before doing the install then the local is higher priority then the device is being loaded. After update look for the quirk is being loaded if its one "standard" or one local quirk and also pleas reporting back if its working OK. |
There are reports that some Blitzwolf SHP 15 plugs (depending on its version) don't report the On/Off update from the physical device. The
herdsman-converterslib have 3 implementations for theTS011Fplugs, 2 of them 'implements' the EnchantedDevice approach:My assumption is that the use of the
EnchantedDevicecannot be harmful. Also I have not located implementations that could be affected if a device starts to behave in a 'standard' way, but there are no guarantees on what will happen and I do not know the scope (of devices) that the change can affect.If the change is considered too risky, I can try to narrow it down to only the devices that have been reported, but I'll need to check how to match 2 compatible signatures and ensure priority is resolved in the desired order:
Fix: #1787