-
Notifications
You must be signed in to change notification settings - Fork 785
New remote_e1 quirks file #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Similar to the existing `remote_h1.py`
Pull Request Test Coverage Report for Build 3268044663
💛 - Coveralls |
xiaomi/aqara/remote_e1.py
Outdated
# triggers when operation_mode == command | ||
# known issue: it seems impossible to know which button being pressed | ||
# when operation_mode == command | ||
(ALT_SHORT_PRESS, BUTTON): {COMMAND: COMMAND_TOGGLE, ENDPOINT_ID: 1, ARGS: []}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are endpoint Id / args needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I do not know 🤷🏻♂️. I have only replicated the implementation of remote_h1.py
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say remove args. command + endpoint should be all we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved the file that was in a wrong path. 🤦🏻♂️
Removed extra args.
Codecov ReportBase: 80.03% // Head: 80.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1820 +/- ##
==========================================
+ Coverage 80.03% 80.48% +0.44%
==========================================
Files 240 241 +1
Lines 7443 7496 +53
==========================================
+ Hits 5957 6033 +76
+ Misses 1486 1463 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks |
Similar to the existing
remote_h1.py
.Fix: #1809
Fix: #1794