Skip to content

New remote_e1 quirks file #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2022
Merged

New remote_e1 quirks file #1820

merged 4 commits into from
Oct 22, 2022

Conversation

javicalle
Copy link
Collaborator

Similar to the existing remote_h1.py.

Fix: #1809
Fix: #1794

Similar to the existing `remote_h1.py`
@coveralls
Copy link

coveralls commented Oct 12, 2022

Pull Request Test Coverage Report for Build 3268044663

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 27 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 80.483%

Files with Coverage Reduction New Missed Lines %
zhaquirks/xiaomi/init.py 27 83.79%
Totals Coverage Status
Change from base Build 3234730911: 0.4%
Covered Lines: 6033
Relevant Lines: 7496

💛 - Coveralls

# triggers when operation_mode == command
# known issue: it seems impossible to know which button being pressed
# when operation_mode == command
(ALT_SHORT_PRESS, BUTTON): {COMMAND: COMMAND_TOGGLE, ENDPOINT_ID: 1, ARGS: []},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are endpoint Id / args needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I do not know 🤷🏻‍♂️. I have only replicated the implementation of remote_h1.py:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say remove args. command + endpoint should be all we need.

Copy link
Collaborator Author

@javicalle javicalle Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved the file that was in a wrong path. 🤦🏻‍♂️
Removed extra args.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 80.03% // Head: 80.48% // Increases project coverage by +0.44% 🎉

Coverage data is based on head (2ee873b) compared to base (687adff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1820      +/-   ##
==========================================
+ Coverage   80.03%   80.48%   +0.44%     
==========================================
  Files         240      241       +1     
  Lines        7443     7496      +53     
==========================================
+ Hits         5957     6033      +76     
+ Misses       1486     1463      -23     
Impacted Files Coverage Δ
zhaquirks/xiaomi/aqara/remote_e1.py 100.00% <100.00%> (ø)
zhaquirks/tuya/ts001x.py 100.00% <0.00%> (ø)
zhaquirks/lidl/TS0501A.py 100.00% <0.00%> (ø)
zhaquirks/lixee/zlinky.py 100.00% <0.00%> (ø)
zhaquirks/lixee/__init__.py 100.00% <0.00%> (ø)
zhaquirks/inovelli/VZM31SN.py 100.00% <0.00%> (ø)
zhaquirks/xiaomi/aqara/plug_mmeu01.py
zhaquirks/xiaomi/aqara/plug_eu.py 100.00% <0.00%> (ø)
zhaquirks/xiaomi/__init__.py 83.79% <0.00%> (+3.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmulcahey dmulcahey merged commit f282203 into zigpy:dev Oct 22, 2022
@javicalle
Copy link
Collaborator Author

Thanks

@javicalle javicalle deleted the patch-4 branch October 22, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants