Add missing stuff for thermostat support#71
Closed
titilambert wants to merge 4 commits into
Closed
Conversation
Author
6 tasks
2 similar comments
rcloran
reviewed
Jan 14, 2018
|
|
||
|
|
||
| class enum16(uint16_t): # noqa: N801 | ||
| _enum = True |
Collaborator
There was a problem hiding this comment.
Why do you need the _enum attribute? Seems unused here, or in your home-assistant PR.
Collaborator
|
It looks like this has been superseded by #91. If that's not the case, please do re-open the PR in zigpy (https://github.com/zigpy/zigpy). |
igorbernstein2
pushed a commit
to igorbernstein2/zigpy
that referenced
this pull request
Feb 10, 2018
According to ZigBee Cluster Library Specification Revision 6 Draft Version 1.0. The Fan Control cluster (0x0202) has 2 attributes both are enum8. Currently zigpy treats all enums as unit8_t & unit16_t, which causes the following error when those attributes are written: [[<WriteAttributesStatusRecord status=Status.INVALID_DATA_TYPE attrid=0>]] This change has been verified to work on the following fan receiver: https://www.homedepot.com/p/Hampton-Bay-Universal-Wink-Enabled-White-Ceiling-Fan-Premier-Remote-Control-99432/206591100. This change is based on: zigpy/bellows#71
rcloran
pushed a commit
to zigpy/zigpy
that referenced
this pull request
Feb 12, 2018
According to ZigBee Cluster Library Specification Revision 6 Draft Version 1.0. The Fan Control cluster (0x0202) has 2 attributes both are enum8. Currently zigpy treats all enums as unit8_t & unit16_t, which causes the following error when those attributes are written: [[<WriteAttributesStatusRecord status=Status.INVALID_DATA_TYPE attrid=0>]] This change has been verified to work on the following fan receiver: https://www.homedepot.com/p/Hampton-Bay-Universal-Wink-Enabled-White-Ceiling-Fan-Premier-Remote-Control-99432/206591100. This change is based on: zigpy/bellows#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.