Aro translate c: Render error diagnostics properly and ignore _Static_assert decls during translation #20865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error count is not set until the diagnostics are actually rendered
This does not completely ignore static asserts - they are validated by aro during parsing; any failures will render an error and non-zero exit code. Emit a warning comment that _Static_asserts are not translated - this matches the behavior of the existing clang-based translate-c. Aro currently does not store source locations for _Static_assert declarations so I've hard-coded token index 0 for now.
ehaas
commented
Jul 29, 2024
| /// Renders errors and fatal errors + associated notes (e.g. "expanded from here"); does not render warnings or associated notes | ||
| /// Terminates with exit code 1 | ||
| fn renderErrorsAndExit(comp: *aro.Compilation) noreturn { | ||
| defer std.process.exit(1); |
There was a problem hiding this comment.
Is it safe/valid to have a defer which runs after control flow reaches the end of a noreturn function or is this too clever?
There was a problem hiding this comment.
defer statements run at the end of the current block, so afaiu the language has to allow it if you added another block scope encompassing the entire function body (that block would then be void instead of noreturn).
I'm not sure how much the compiler would gain by requiring this extra step of users, so I wouldn't see a point in disallowing it as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this only ignores
_Static_assertduring translation, which matches the behavior of clang-basedtranslate-c. The_Static_assertconditions are validated during parsing and any failures result in an error.Previously we were not rendering errors and exiting with a non-zero status. I wasn't sure how to add a test for this to the existing translate-c tests but I tested manually with:
./stage3/bin/zig run -fno-clang -fno-llvm -fno-lld --dep aro -Mroot=../lib/compiler/aro_translate_c.zig -Maro=../lib/compiler/aro/aro.zig -- ~/test.ctest.c contents:
Output: