-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetFileInformationByHandle compile error #14829
Conversation
The wrapper function was mistakenly referencing ntdll.zig when the actual function is declared in kernel32.zig.
LGTM. Eventually we'd like to use the Ntdll calls for file stuff, because this is highly unlikely to change. For file information this would be NtQueryInformationFile. see #1840. |
This is already the case, unless you mean that Zig should supply a
|
Ok cool, is there anything else I can do to get this merged? Or just wait until an admin approves the PR? It's my first contribution so I'm not sure how this works. |
Nothing you need to do, just need to wait. |
Thank you for the patch. I think I would prefer to entirely remove this function from the standard library rather than fix it. Related issue: #4426 |
Ok, that makes sense given the std lib doesn't use this function at all. |
Latest change delete the function so no one will make the same mistake again. :) I think #14841 should probably clean up the dangling GetFileInformationByHandleEx declaration in kernel32.zig as well. |
* Fix GetFileInformationByHandle compile error The wrapper function was mistakenly referencing ntdll.zig when the actual function is declared in kernel32.zig. * delete GetFileInformationByHandle since it's not used by the stdlib
The wrapper function was mistakenly referencing ntdll.zig when the actual function is declared in kernel32.zig.