-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Darwin: FSWatch API #1333
Conversation
std/event/loop.zig
Outdated
} | ||
} | ||
|
||
// LinuxOsData MacOsData are not directly | ||
// included into the struct because the compiler cannot resolve | ||
// os specific members on other platforms -- this could be a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewrk hey, is this a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still thinking about this one. We have to decide whether name resolution is lazy or not. This is actually related to #21 and I'll use the insight from implementing that issue when figuring out how to deal with this situation.
I think we are in a pretty good place.
|
…e support may use them;
1572815
to
93771eb
Compare
Reference ziglang#1349 for help/understanding;
I think that we will use FSEvents on MacOS eventually. However, a pure kqueue solution (with an fd per file) will still be necessary on some of the BSDs. So we may as well implement that, because it's simpler and pushes off #1349 to solve later. |
@andrewrk I agree about kqueue. We should eventually have these implementations for FS watching:
I also found this list of limitations from the @emcrisostomo's fswatch project:
|
I think the biggest challenge we face in order to support more target platforms is infrastructure - we absolutely must have CI building and testing for all supported platforms. See #835. Once we have automated testing set up for one of the BSDs, supporting it will be a piece of cake. |
Let's solve #1349 before we add any dependencies on frameworks to the standard library. We can re-evaluate using FSWatch later. |
This is the Darwin Branch of #1294 ;
Highlights include new platform agnostic API.